Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem with rebinding singletons. #60

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

butschster
Copy link
Member

No description provided.

@butschster butschster added the bug Something isn't working label Aug 16, 2023
@butschster butschster self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.77% ⚠️

Comparison is base (c8d2e4c) 41.36% compared to head (b82b41d) 40.60%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #60      +/-   ##
============================================
- Coverage     41.36%   40.60%   -0.77%     
+ Complexity      319      309      -10     
============================================
  Files            34       33       -1     
  Lines          1095      953     -142     
============================================
- Hits            453      387      -66     
+ Misses          642      566      -76     
Files Changed Coverage Δ
src/Http/FakeHttp.php 33.82% <0.00%> (-4.96%) ⬇️
src/Traits/InteractsWithCore.php 59.70% <50.00%> (-3.59%) ⬇️
src/TestCase.php 78.68% <100.00%> (-1.62%) ⬇️
src/Traits/InteractsWithEvents.php 100.00% <100.00%> (ø)
src/Traits/InteractsWithExceptions.php 63.63% <100.00%> (ø)
src/Traits/InteractsWithMailer.php 100.00% <100.00%> (ø)
src/Traits/InteractsWithQueue.php 100.00% <100.00%> (ø)
src/Traits/InteractsWithScaffolder.php 93.75% <100.00%> (+1.06%) ⬆️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster added this to the 2.x milestone Aug 16, 2023
@butschster butschster merged commit 763ce92 into 2.x Aug 16, 2023
@butschster butschster deleted the hotfix/remove-binding-before-bind-new-service branch August 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants